Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Drawable / Legacy renderer matrix Linux CI #1720

Merged
merged 27 commits into from
Oct 5, 2023
Merged

Fix Drawable / Legacy renderer matrix Linux CI #1720

merged 27 commits into from
Oct 5, 2023

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Oct 3, 2023 •
edited
Loading

@stefankarschti

Getting this assertion error now that the Linux tests run for the Drawable path.

mbgl-test-runner: /home/runner/work/maplibre-native/maplibre-native/src/mbgl/gl/drawable_gl.cpp:130: void mbgl::gl::DrawableGL::bindUniformBuffers() const: Assertion `false' failed.

@louwers louwers added the github_actions Pull requests that update GitHub Actions code label Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (bace5ef) 85.71% compared to head (aeaaced) 85.69%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1720      +/-   ##
==========================================
- Coverage   85.71%   85.69%   -0.02%     
==========================================
  Files         564      564              
  Lines       27772    27760      -12     
==========================================
- Hits        23804    23790      -14     
- Misses       3968     3970       +2
Files Coverage Δ
include/mbgl/util/string_indexer.hpp 100.00% <100.00%> (ø)
src/mbgl/gl/offscreen_texture.cpp 80.55% <ø> (ø)
src/mbgl/gl/upload_pass.cpp 91.93% <ø> (ø)
src/mbgl/renderer/layers/render_circle_layer.cpp 93.12% <ø> (ø)
...gl/renderer/layers/render_fill_extrusion_layer.cpp 94.49% <ø> (ø)
src/mbgl/renderer/layers/render_fill_layer.cpp 99.28% <ø> (ø)
src/mbgl/renderer/layers/render_heatmap_layer.cpp 87.03% <ø> (ø)
...rc/mbgl/renderer/layers/render_hillshade_layer.cpp 83.33% <ø> (ø)
src/mbgl/renderer/layers/render_line_layer.cpp 95.65% <ø> (ø)
src/mbgl/renderer/layers/render_raster_layer.cpp 92.72% <ø> (ø)
... and 4 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louwers louwers requested a review from stefankarschti October 3, 2023 18:11
@stefankarschti
Copy link
Collaborator

@stefankarschti

Getting this assertion error now that the Linux tests run for the Drawable path.

mbgl-test-runner: /home/runner/work/maplibre-native/maplibre-native/src/mbgl/gl/drawable_gl.cpp:130: void mbgl::gl::DrawableGL::bindUniformBuffers() const: Assertion `false' failed.

The StringIndexer tests corrupt the global string list, because the StringIndexer is a singleton. Then the core is incorrectly using indexes that have been replaced and attempts to use them for UBO retrieval.

To move ahead please disable StringIndexer.* tests temporarily, while I work on a proper fix.

@stefankarschti stefankarschti mentioned this pull request Oct 4, 2023
Closed
@louwers louwers mentioned this pull request Oct 5, 2023
Open
@louwers louwers merged commit 1965cfe into maplibre:main Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcristici alexcristici alexcristici approved these changes

@stefankarschti stefankarschti Awaiting requested review from stefankarschti

@sjg-wdw sjg-wdw Awaiting requested review from sjg-wdw

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louwers @stefankarschti @alexcristici